Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: submit timestamps in block descriptors #1032

Merged
merged 6 commits into from
Aug 24, 2024

Conversation

spoo-bar
Copy link
Contributor

@spoo-bar spoo-bar commented Aug 22, 2024

Ref: dymensionxyz/dymension#981

  • Convert the nanosecond block header timestamp to go time.Time and submit it with block descriptors

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@spoo-bar spoo-bar marked this pull request as ready for review August 22, 2024 12:45
@spoo-bar spoo-bar requested a review from a team as a code owner August 22, 2024 12:45
@danwt danwt added the security label Aug 22, 2024
@omritoptix omritoptix merged commit 9aff932 into main Aug 24, 2024
7 checks passed
@omritoptix omritoptix deleted the spoorthi/rollapp-light-client branch August 24, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants