Fix int64 normalization #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We should check the format of `integer` * int32 and int64 are only the domain of type: integer
bhelx
commented
Nov 11, 2024
src/normalizer.ts
Outdated
| return new Int32Type(s) | ||
| if (s.format === 'int32') return new Int32Type(s) | ||
| if (s.format === 'int64') return new Int64Type(s) | ||
| this.recordError(`IDK how to parse this integer: ${s.format}`); |
Contributor
Author
There was a problem hiding this comment.
We should decide what to do when there is no format for type = number and integer. OpenAPI supports generic numbers and ints: https://swagger.io/docs/specification/v3_0/data-models/data-types/
I think perhaps we want to default them to double and int64 respectively. Maybe after we rollout int64 support everywhere.
Contributor
Author
There was a problem hiding this comment.
I'm gonna default to int64 as not to break any documents that may have been using integer without a format. so will need to update all the bindgens before upgrading this library.
bhelx
force-pushed
the
fix-int64-normalization
branch
from
c2d5b0f to
e2c924c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integer