This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Added for OmniOS illumos distribution #2196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-fidd
force-pushed
the
omnios-support
branch
3 times, most recently
from
5de301d to
edad01f
Compare
matt-fidd
force-pushed
the
omnios-support
branch
from
9e59bc4 to
c3beb21
Compare
matt-fidd
changed the title
hykilpikonna
approved these changes
Oct 4, 2022
hykilpikonna
reviewed
Oct 4, 2022
Comment on lines
-1385
to
1396
| case $title_fqdn in | ||
| on) hostname=$(hostname -f) ;; | ||
| case $os-$title_fqdn in | ||
| illumos-on|Solaris-on) | ||
| hostname=$(hostname) | ||
| domainname=$(domainname) | ||
| [[ -n "$domainname" ]] && hostname+=".$domainname" | ||
| ;; | ||
| *-on) hostname=$(hostname -f) ;; | ||
| *) hostname=${HOSTNAME:-$(hostname)} ;; | ||
| esac |
There was a problem hiding this comment.
Maybe we should change this to two case statements. I think it would make the logic clearer.
case $title_fqdn in
on)
case $os in
illumos|Solaris)
hostname=$(hostname)
domainname=$(domainname)
[[ -n "$domainname" ]] && hostname+=".$domainname"
;;
*)
hostname=$(hostname -f)
;;
esac
;;
*)
hostname=${HOSTNAME:-$(hostname)}
hostname=${hostname%.*}
;;
esac
hykilpikonna
added a commit
to hykilpikonna/hyfetch
that referenced
this pull request
Oct 4, 2022
…os distribution Upstream PR: dylanaraps/neofetch#2196 Thanks to @matt-fidd Co-authored-by: matt <matt@fiddaman.net>
|
Thank you for your contribution! This PR is merged into hyfetch since this repo (dylanaraps/neofetch) seems no longer maintained. HyFetch is a fork of neofetch with LGBTQ pride flags, but the repo also maintains an updated version of the original neofetch, addressing many pull requests that are not merged in the original repo. Read the "Running Updated Original Neofetch" section for more info! |
hayatehay
added a commit
to nmimusic/unifetch
that referenced
this pull request
Oct 19, 2022
mrquantumoff
added a commit
to mrquantumoff/nexfetch
that referenced
this pull request
Jan 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ascii art for the OmnioOS illumos distribution. I've attached an image to the PR so that you can see what it looks like!
Thank you!