This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Fix Windows 11 detection #1848 #1889
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also it will be good to fix the Windows 7 logo when running neofetch via scoop. |
|
(#1981 seems to have the relevant art - I'd recommend adding it or a variation of it in this PR) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace hardcoded "on Windows 10" with the output of
wmic os get Captioncalled via PowerShell interop when running on WSL, fixing #1848It also correctly shows Fluent as DE when running natively on Windows 11 instead of Aero.
Issues
It now shows "Microsoft Windows" instead of just "Windows" because that's what wmic returns.