-
Notifications
You must be signed in to change notification settings - Fork 1.7k
neofetch: Strengthen scoop/choco app reporting #1642
base: master
Are you sure you want to change the base?
Conversation
What happens when cygpath is unavailable? (Is it available if CYGWIN is absent? ie, just wsl or msys2 etc). |
Cygwin, msys2, mingw, and git-bash environments all have While wsl runs under Windows, it does not have |
@dylanaraps Why is this PR labeled as "Not mergeable"? |
@dylanaraps Ping. |
|
||
# Count chocolatey packages. | ||
[[ -d /cygdrive/c/ProgramData/chocolatey/lib ]] && \ | ||
dir /cygdrive/c/ProgramData/chocolatey/lib/* | ||
has choco && dir "$ProgramData"/chocolatey/lib/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good. I've previously changed it to has choco && tot choco list --localonly
but choco list
is really slow (>3s)
…choco app reporting Upstream PR: dylanaraps/neofetch#1642 Thanks to @rasa Co-authored-by: Ross Smith II <ross@smithii.com>
Thank you for your contribution! This PR is merged into hyfetch since this repo (dylanaraps/neofetch) seems no longer maintained. HyFetch is a fork of neofetch with LGBTQ pride flags, but the repo also maintains an updated version of the original neofetch, addressing many pull requests that are not merged in the original repo. Read the "Running Updated Original Neofetch" section for more info! |
Description
This PR enhances scoop and chocolatey package reporting, as it:
cygpath
to determine where drive C: is mounted (while defaulting to/cygdrive/c
).Tested and working in Cygwin, Msys2, git-bash, and WSL environments, where C: is mounted at
/c
and both%SCOOP%
and%SCOOP_GLOBAL%
are used.