This repository has been archived by the owner on Apr 21, 2024. It is now read-only.
New workspace model #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
housel
approved these changes
Dec 20, 2022
commands/utils.dylan
Outdated
| @@ -7,7 +7,7 @@ Synopsis: Utilities for use by dylan-tool commands | |||
| // Using the comment markers enables recovery if someone commits a string | |||
| // other than "HEAD" by accident. git's `ident` attribute doesn't use tag | |||
| // names and `filter` looks more complex than it's worth. | |||
| define constant $dylan-tool-version :: <string> = /*__*/ "HEAD" /*__*/; | |||
| define constant $dylan-tool-version :: <string> = /*__*/ "v0.7.0-5-g0b64cb3" /*__*/; | |||
There was a problem hiding this comment.
Somebody committed a string other than HEAD by accident.
There was a problem hiding this comment.
A shocking lapse of mental coordination. Fixed.
(Do let me know if there's a better way to accomplish putting the version in the code.)
| ``dylan-package.json`` file in the top-level directory which describes its | ||
| attributes. A package currently corresponds to a single Git repository. A | ||
| package has a set of versioned releases. | ||
| ``dylan-package.json`` file in the top-level directory. A package currently |
There was a problem hiding this comment.
Neat. Let me defer this for now, since I need to update all file references. I had been trying to decide between foo, "foo", and foo for files and this answers that question.
|
|
||
| workspace | ||
| A directory containing a "workspace.json" file. Most ``dylan`` commands may be | ||
| run from anywhere within the workspace directory. | ||
| The directory in which the ``dylan`` tool operates. Effectively this means a |
There was a problem hiding this comment.
Deferring to separate PR again.
| A directory containing a "workspace.json" file. Most ``dylan`` commands may be | ||
| run from anywhere within the workspace directory. | ||
| The directory in which the ``dylan`` tool operates. Effectively this means a | ||
| workspace is where the "_build" and "registry" directories are generated. In |
| ``dylan`` subcommands need to be run inside a workspace so that they can | ||
| interrelated packages. The ``dylan`` tool often needs to find the root of the | ||
| workspace, for example to decide where to write the "registry" directory or to | ||
| invoke ``dylan-compiler``. It does this by looking for one of the following |
| invoke ``dylan-compiler``. It does this by looking for one of the following | ||
| files, in the order shown, and by using the directory containing the file: | ||
|
|
||
| 1. workspace.json -- A place to put workspace configuration settings. |
See the doc changes in this commit for a full explanation of how workspaces work now. In short, dylan-package.json usually suffices to define a workspace, but workspace.json (if it exists) overrides. The `dylan new application` and `dylan new library` commands no longer generate a workspace.json file.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the doc changes in this commit for a full explanation of how workspaces
work now. In short, dylan-package.json usually suffices to define a workspace,
but workspace.json (if it exists) overrides.
The
dylan new applicationanddylan new librarycommands no longer generatea workspace.json file.