Fix list of exported function names #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* many had an unnecessary preceding backslash * generic-function-mandatory-keywords was split across two lines
Member
Author
|
I've now tested this here: https://docs.opendylan.org/books/drm/Exported_Names |
housel
reviewed
Jun 29, 2023
| \~ | ||
| \~= | ||
| \~== | ||
| * |
Member
There was a problem hiding this comment.
Treating these operators as names usually does require an escape backslash, so I think it would be best to keep them.
Member
Author
There was a problem hiding this comment.
I think I must disagree. This section is specifically listing names, not talking about how they might be imported or exported, and it could be confusing to a newcomer as to whether the name includes the backslash or not.
(It could be confusing when they get to the point of importing these names individually, too, but chances are they will never have to do that.)
Furthermore, we don't do it for other names such as := and for, which IIRC will have the same problem.
housel
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Untested. Creating a pull request so I don't forget about this branch. I need to figure out how to setup a web server that will automatically assume
.htmlfile extensions. Why is there no README in this repo grumble grumble.)