Update docs and package file #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Less maintenance work if we use latest for dev deps.
Package doc toctrees need to be marked `:hidden:` or their ToC will be included in the main opendylan.org ToC. That's not a problem, per se, but it also means (apparently) that the title of the document is included in the opendylan.org ToC, which I don't want; I want each package's ToC entry to be only the name of the package, for consistency. Also removing the `modindex`, which is Python specific, and `search` which is not needed with the Furo theme.
fraya
reviewed
May 10, 2024
| @@ -8,8 +8,8 @@ | |||
| "contact": "dylan-lang@googlegroups.com", | |||
| "dependencies": [], | |||
| "dev-dependencies": [ | |||
| "testworks@3.2.0", | |||
| "sphinx-extensions@0.2.0" | |||
| "testworks", | |||
There was a problem hiding this comment.
I agree that is less maintenance work, but it is a good practice? Is ok for developer dependencies only?
There was a problem hiding this comment.
Right, I only do it for dev deps. (And my world is colored by the fact that we used to do everything at master all the time, so using package versions at all is somewhat new in Dylandia.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.