This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
Implement Limit Orders #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrendanChou
force-pushed
the
bc_limitorders
branch
4 times, most recently
from
5437f01 to
29cf40c
Compare
AntonioJuliano
suggested changes
Jul 11, 2019
BrendanChou
force-pushed
the
bc_limitorders
branch
2 times, most recently
from
c723b24 to
aac31c4
Compare
added 2 commits
July 11, 2019 16:35
BrendanChou
force-pushed
the
bc_limitorders
branch
6 times, most recently
from
6542925 to
ed75ef3
Compare
BrendanChou
force-pushed
the
bc_limitorders
branch
from
ed75ef3 to
b82f536
Compare
AntonioJuliano
suggested changes
Jul 15, 2019
| Require.that( | ||
| newFillAmount <= order.makerAmount, | ||
| FILE, | ||
| "Cannot overfill order" |
There was a problem hiding this comment.
Did you mean to do this?
BrendanChou
force-pushed
the
bc_limitorders
branch
3 times, most recently
from
095140c to
43dce32
Compare
BrendanChou
force-pushed
the
bc_limitorders
branch
from
43dce32 to
ab03f05
Compare
| Require.that( | ||
| newFillAmount <= order.makerAmount, | ||
| FILE, | ||
| "Cannot overfill order" |
There was a problem hiding this comment.
Sorry, I meant can you add those two things to the revert message
BrendanChou
force-pushed
the
bc_limitorders
branch
3 times, most recently
from
f4ba218 to
43d9f07
Compare
BrendanChou
force-pushed
the
bc_limitorders
branch
from
43d9f07 to
6130a2e
Compare
AntonioJuliano
approved these changes
Jul 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.