refactor getLiquidationSpread #154

BrendanChou · 2019-03-06T00:03:12Z

Just the solidity changes of #153

Does not change any meaningful functionality on the base protocol
- add getLiquidationSpreadForPair() function to Storage.sol which abstracts away some logic from the _getLiquidationPrices() function in OperationImpl.sol
- Adds public getter function for getLiquidationSpreadForPair()
- Remove add() function in Decimal.sol library, replace with onePlus() function which adds a decimal to a decimal of value 1.
bugfixes in Expiry
- now respects the spread premiums on the two markets involved
- now ensures that the repaid asset does not end up positive (rather than does not end up negative)

AntonioJuliano

contracts/protocol/lib/Storage.sol

BrendanChou requested a review from AntonioJuliano March 6, 2019 00:03

BrendanChou mentioned this pull request Mar 6, 2019

Add Expiry tests #153

Merged

AntonioJuliano reviewed Mar 6, 2019

View reviewed changes

contracts/protocol/lib/Storage.sol Outdated Show resolved Hide resolved

AntonioJuliano previously approved these changes Mar 6, 2019

View reviewed changes

BrendanChou dismissed AntonioJuliano’s stale review via 63aac3c March 6, 2019 00:33

BrendanChou force-pushed the bc_liquidationspread branch from b98929e to 63aac3c Compare March 6, 2019 00:33

refactor getLiquidationSpreadForPair

93a623c

BrendanChou force-pushed the bc_liquidationspread branch from 63aac3c to 93a623c Compare March 6, 2019 00:45

BrendanChou merged commit ec20d87 into master Mar 6, 2019

BrendanChou deleted the bc_liquidationspread branch March 6, 2019 00:51

Provide feedback