Skip to content

Component button specs update #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 27, 2021
Merged

Component button specs update #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
163d332
Update spacing specs
aweell Sep 24, 2021
7a65e1f
Update component images
aweell Sep 24, 2021
23b8f48
Update dialog component images
aweell Sep 27, 2021
9f43b39
Update upload component images
aweell Sep 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified contributing/assets/components/button_images.xd
View file
Open in desktop
Binary file not shown.
Binary file modified contributing/assets/components/dialog_images.xd
View file
Open in desktop
Binary file not shown.
Binary file modified contributing/assets/components/upload_images.xd
View file
Open in desktop
Binary file not shown.
47 changes: 26 additions & 21 deletions guidelines/components/button/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,11 @@ These values can be applied independently to each side of the component:

| Component token | Element | Token | Value |
| :---------------------------------- | :-------------------------- | :----------------------- | :---------- |
| `primaryHoverBackgroundColor` | Container fill:hover | `color-purple-800` | #4b1c7d |
| `primaryActiveBackgroundColor` | Container fill:active | `color-purple-900` | #321353 |
| `primaryHoverBackgroundColor` | Container fill:hover | `color-purple-800` | #4b1c7d |
| `primaryActiveBackgroundColor` | Container fill:active | `color-purple-900` | #321353 |
| `primaryDisabledBackgroundColor` | Container fill:disabled | `color-grey-100` | #f2f2f2 |
| `primaryDisabledFontColor` | Label:disabled | `color-grey-500` | #999999 |
| `secondaryFocusBorderColor` | Container border:focus | `color-blue-600` | #0095ff |
| `secondaryFocusBorderColor` | Container border:focus | `color-blue-600` | #0095ff |

#### Border

Expand All @@ -124,12 +124,15 @@ These values can be applied independently to each side of the component:
| `primaryBorderRadius` | Label | `font-regular` | 400 |


#### Padding
#### Spacing

| Component token | Element | Core token | Value |
| :----------------------------- | :--------------- | :---------------- | :-------------- |
| `primaryPaddingLeft` | Container | `spacing-03` | 0.5rem / 8px |
| `primaryPaddingRight` | Container | `spacing-03` | 0.5rem / 8px |
| `primaryPaddingTop` | Container | `spacing-05` | 1rem / 16px |
| `primaryPaddingBottom` | Container | `spacing-05` | 1rem / 16px |

| Component token | Element | Core token | Value |
| :-------------------------- | :--------------- | :------------- | :---------------- |
| `primaryPaddingTop` | Label | `spacing-04` | 0.75 rem / 12px |
| `primaryPaddingBottom` | Label | `spacing-04` | 12px / 0.75 rem |

### Secondary

Expand Down Expand Up @@ -172,12 +175,14 @@ These values can be applied independently to each side of the component:
| `secondaryFontWeight` | Label | `font-regular` | 400 |


#### Padding
#### Spacing

| Component token | Element | Core token | Value |
| :----------------------------- | :--------------- | :---------- | :----------------- |
| `secondaryPaddingTop` | Label | `-` | 10px / 0.75 rem |
| `secondaryPaddingBottom` | Label | `-` | 10px / 0.75 rem |
| Component token | Element | Core token | Value |
| :----------------------------- | :--------------- | :---------------- | :-------------- |
| `secondaryPaddingLeft` | Container | `spacing-03` | 0.5rem / 8px |
| `secondaryPaddingRight` | Container | `spacing-03` | 0.5rem / 8px |
| `secondaryPaddingTop` | Container | `spacing-05` | 1rem / 16px |
| `secondaryPaddingBottom` | Container | `spacing-05` | 1rem / 16px |


### Text
Expand All @@ -199,7 +204,7 @@ These values can be applied independently to each side of the component:
| `textActiveBackgroundColor` | Container fill:active | `color-purple-200` | #e5d5f6 |
| `textDisabledBackgroundColor` | Container fill:disabled | `color-grey-100` | #f2f2f2 |
| `textDisabledFontColor` | Label:disabled | `color-grey-500` | #999999 |
| `secondaryFocusBorderColor` | Container border:focus | `color-blue-600` | #0095ff |
| `secondaryFocusBorderColor` | Container border:focus | `color-blue-600` | #0095ff |


#### Border
Expand All @@ -221,14 +226,14 @@ These values can be applied independently to each side of the component:
| `textFontWeight` | Label | `font-regular` | 400 |


#### Padding

| Component token | Element | Core token | Value |
| :--------------------------- | :--------------- | :------------------- | :---------------- |
| `textPaddingTop` | Label | `spacing-04` | 12px / 0.75 rem |
| `textPaddingBottom` | Label | `spacing-04` | 12px / 0.75 rem |

#### Spacing

| Component token | Element | Core token | Value |
| :-------------------------- | :--------------- | :---------------- | :-------------- |
| `textPaddingLeft` | Container | `spacing-03` | 0.5rem / 8px |
| `textPaddingRight` | Container | `spacing-03` | 0.5rem / 8px |
| `textPaddingTop` | Container | `spacing-05` | 1rem / 16px |
| `textPaddingBottom` | Container | `spacing-05` | 1rem / 16px |


## Icon Usage
Expand Down
Binary file modified guidelines/components/button/images/button_anatomy.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified guidelines/components/button/images/button_icon.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified guidelines/components/button/images/button_specs.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified guidelines/components/button/images/button_states.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified guidelines/components/button/images/button_variants.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed guidelines/components/button/images/miniature.png
View file
Open in desktop
Binary file not shown.
Binary file modified guidelines/components/button/miniature.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified guidelines/components/dialog/images/dialog_anatomy.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified guidelines/components/dialog/images/dialog_content.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified guidelines/components/dialog/images/dialog_overlay.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified guidelines/components/dialog/images/dialog_specs.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified guidelines/components/upload/images/upload_default.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified guidelines/components/upload/images/upload_error.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified guidelines/components/upload/images/upload_preview.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified guidelines/components/upload/images/upload_success.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.