Skip to content

Conversation

@Mil4n0r
Copy link
Collaborator

@Mil4n0r Mil4n0r commented Sep 5, 2025

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

We still had plenty of files related to old theming strategy which were no longer useful, so I have done an overall cleanup, also taking the opportunity to increase the consistency of our code conventions (using arrow functions over normal functions when possible, removing unneeded empty wrappers, etc.), removing unsupported characters and fixed a few minor typos or missing texts in the doc.

I still have a few more changes that I would like to add such as replacing all the "rem", "em" and "px" with the correct css tokens and redoing the spacing logic for those components that have it dynamic, but that's a bigger task that can wait.

@Mil4n0r Mil4n0r marked this pull request as draft September 5, 2025 12:52
@Mil4n0r Mil4n0r marked this pull request as ready for review September 9, 2025 08:54
@Mil4n0r Mil4n0r merged commit f35154e into master Sep 10, 2025
4 checks passed
@Mil4n0r Mil4n0r deleted the Mil4n0r/code_cleanup branch September 10, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants