Dead code cleanup and improved consistency of code #2281
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
(Check off all the items before submitting)
/libdirectory./websiteas needed.We still had plenty of files related to old theming strategy which were no longer useful, so I have done an overall cleanup, also taking the opportunity to increase the consistency of our code conventions (using arrow functions over normal functions when possible, removing unneeded empty wrappers, etc.), removing unsupported characters and fixed a few minor typos or missing texts in the doc.
I still have a few more changes that I would like to add such as replacing all the "rem", "em" and "px" with the correct css tokens and redoing the spacing logic for those components that have it dynamic, but that's a bigger task that can wait.