Skip to content

Conversation

@Jialecl
Copy link
Collaborator

@Jialecl Jialecl commented Jan 13, 2025

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Purpose
ariaLabel prop added to textInput to input components

@Mil4n0r Mil4n0r self-requested a review January 13, 2025 15:09
@Mil4n0r Mil4n0r self-assigned this Jan 13, 2025
Copy link
Collaborator

@Mil4n0r Mil4n0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. However, for consistency, I would check aria-label inside the test files for NumberInput, PasswordInput and DateInput too. I know it may sound redundant but we are already checking other aria attributes that come from TextInput implementation in them (e.g. check NumberInput.test.tsx checking aria-autocomplete). I think that it is, overall, a good practice in case the implementation for these components changes in the future.

@Mil4n0r Mil4n0r merged commit d016030 into master Jan 14, 2025
4 checks passed
@Mil4n0r Mil4n0r deleted the jialecl-textInput-ariaLabel branch January 14, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants