Skip to content

Conversation

@GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Aug 6, 2024

Checklist

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Removing DxcBarChart from the Halstack library (library only, not in the documentation site, that's another PR).

Closes #2038, #2068

@GomezIvann GomezIvann marked this pull request as ready for review August 6, 2024 10:48
@Mil4n0r Mil4n0r self-requested a review August 6, 2024 11:05
@GomezIvann GomezIvann changed the title Removing Bar Chart component from Halstack Removing Bar Chart component from lib Aug 6, 2024
Copy link
Collaborator

@Mil4n0r Mil4n0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, don't forget to remove cloudscape remaining references when removing it from the site.

@Mil4n0r Mil4n0r merged commit 99edeb7 into master Aug 6, 2024
@Mil4n0r Mil4n0r deleted the gomezivann/bar-chart-removal branch August 6, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bar Chart is not exported with our custom theme

3 participants