Skip to content

Conversation

@GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Jun 26, 2024

Checklist

  • The Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Turning the halstack project and repository into a mono-repo, using Turborepo.

Commands to test the application:

  • npm install at the top of the repository.
  • Install turbo command (it is not mandatory): npm install turbo --global. If you prefer, you can execute every command with just npm run.
  • turbo dev > Launches the dev environment
  • turbo build > Builds all packages and application
  • turbo lint > Lints the code of the repository
  • turbo format > Formats the code with Prettier
  • turbo test > Unit tests
  • turbo storybook > Launch storybook.
  • turbo storybook:accessibility (and :ci variant) > Launch accessibility test over the stories.

@GomezIvann GomezIvann marked this pull request as ready for review June 27, 2024 09:21
@Mil4n0r Mil4n0r self-requested a review June 28, 2024 07:30
@GomezIvann GomezIvann requested a review from Jialecl June 28, 2024 12:37
Mil4n0r
Mil4n0r previously approved these changes Jul 3, 2024
Copy link
Collaborator

@Mil4n0r Mil4n0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. Have to test publish workflows after merging.

@Mil4n0r Mil4n0r self-requested a review July 4, 2024 09:33
@Mil4n0r Mil4n0r dismissed their stale review July 4, 2024 09:34

Identified a few problems

@Mil4n0r
Copy link
Collaborator

Mil4n0r commented Jul 4, 2024

There is a small problem causing the project to create %SystemDrive%/ directory.

More info here:

vercel/turborepo#8553

@Mil4n0r Mil4n0r merged commit 409de16 into master Jul 8, 2024
@Mil4n0r Mil4n0r deleted the gomezivann/turbo-halstack branch July 8, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants