Skip to content

Add new tokens for the Text Input #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 12, 2024
Merged

Add new tokens for the Text Input #2017

merged 5 commits into from
Jun 12, 2024

Conversation

@GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Jun 11, 2024 •
edited
Loading

Checklist

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Summary:

  1. New tokens for the Text Input. Users can now fully customise (even remove) the separator between the input value and the prefix.
    image
    image
  2. Updated Alert description based on user's feedback.

Closes #1742

@GomezIvann GomezIvann marked this pull request as ready for review June 11, 2024 10:02
@raquelarrojo raquelarrojo self-requested a review June 12, 2024 08:59
@raquelarrojo raquelarrojo self-assigned this Jun 12, 2024
raquelarrojo
raquelarrojo requested changes Jun 12, 2024
View reviewed changes
@raquelarrojo raquelarrojo self-requested a review June 12, 2024 11:11
@raquelarrojo raquelarrojo merged commit 4e3dbad into master Jun 12, 2024
@raquelarrojo raquelarrojo deleted the gomezivann/component-udpates branch June 12, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raquelarrojo raquelarrojo raquelarrojo approved these changes

Assignees

@raquelarrojo raquelarrojo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DxcTextInput - have option for Prefix where it has divider ( | ) sign which is confusing, Couldn't find any option to remove the same

3 participants

@GomezIvann @raquelarrojo