Select updates #2009
Merged
Select updates #2009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mil4n0r
requested changes
May 29, 2024
Collaborator
Mil4n0r
left a comment
Mil4n0r
left a comment
There was a problem hiding this comment.
I proposed a few small changes.
I assume that the changes to the spacing and sizes have been validated by the designers right?
Mil4n0r
reviewed
May 29, 2024
Collaborator
Author
The changes in the spacing are due to some adjustments to make it look more alike the design version in Figma. The height of the option goes from |
Mil4n0r
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
/libdirectory./websiteas needed.Description
Summary of changes:
Closes #2008