Fixed some weird size behaviors in some input components #1974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mil4n0r
approved these changes
May 3, 2024
Collaborator
Mil4n0r
left a comment
Mil4n0r
left a comment
There was a problem hiding this comment.
I have seen that there are multiple commas added, this is due to the trailingComma parameter not being set for prettier. It has no impact and will be included in the Code Quality PR though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
(Check off all the items before submitting)
/libdirectory./websiteas needed.Purpose
This PR fixes some strange behavior in the size of some of our input components.
Instead of components with 100% width being pushed by other components with a fixed width it was the other way around.
The password and number were not behaving correctly inside a flex component when the size was set to
fillParent.Closes #1970