-
Notifications
You must be signed in to change notification settings - Fork 18
Added new Divider component
#1835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kukoc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to quickly prepare the component api using your template and share it to have a quick review from the team devs.
…/halstack-react into Mil4n0r/divider-component
|
I also added a change at SideNav to match the colors used in the rest of the dividers. |
Mil4n0r
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still a pending discussion regarding whether or not we will add a field to address accessibility scenarios where screen readers would want to detect the Divider if it is not only decorative but serves as a semantic separator.
It was proposed by @GomezIvann to add a new decorative field that sets aria-hidden and is set as true by default.
…/halstack-react into Mil4n0r/divider-component
|
It has been decided to add the decorative prop to the component API for accessibility purposes (regarding screen readers and divider visibility). The component is now ready to review. We have to take into account that, after the component is added, it should be integrated into the existing parts of the code that use dividers (SideNav, Contextual Menu...) |
…/halstack-react into Mil4n0r/divider-component
Checklist
/libdirectory./websiteas needed.Description
A new
Dividercomponent is required based on the following design and props: https://preview.uxpin.com/c59c7c54afe8009ba5082153d70cd86fb91be7e7#/pages/165565398/simulate/no-panelsCloses #1834