Skip to content

Conversation

@Mil4n0r
Copy link
Collaborator

@Mil4n0r Mil4n0r commented Feb 19, 2024

Checklist

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
A new Divider component is required based on the following design and props: https://preview.uxpin.com/c59c7c54afe8009ba5082153d70cd86fb91be7e7#/pages/165565398/simulate/no-panels

Closes #1834

@Mil4n0r Mil4n0r marked this pull request as ready for review February 19, 2024 11:38
@kukoc kukoc self-requested a review February 20, 2024 09:18
Copy link
Collaborator

@kukoc kukoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to quickly prepare the component api using your template and share it to have a quick review from the team devs.

@Mil4n0r Mil4n0r marked this pull request as draft February 20, 2024 11:04
@Mil4n0r Mil4n0r requested a review from kukoc February 21, 2024 13:05
@Mil4n0r Mil4n0r marked this pull request as ready for review February 21, 2024 13:05
@Mil4n0r
Copy link
Collaborator Author

Mil4n0r commented Feb 28, 2024

I also added a change at SideNav to match the colors used in the rest of the dividers.

@Mil4n0r Mil4n0r requested a review from GomezIvann February 28, 2024 15:51
Copy link
Collaborator Author

@Mil4n0r Mil4n0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still a pending discussion regarding whether or not we will add a field to address accessibility scenarios where screen readers would want to detect the Divider if it is not only decorative but serves as a semantic separator.

It was proposed by @GomezIvann to add a new decorative field that sets aria-hidden and is set as true by default.

@Mil4n0r
Copy link
Collaborator Author

Mil4n0r commented Mar 5, 2024

It has been decided to add the decorative prop to the component API for accessibility purposes (regarding screen readers and divider visibility).

The component is now ready to review. We have to take into account that, after the component is added, it should be integrated into the existing parts of the code that use dividers (SideNav, Contextual Menu...)

@Mil4n0r Mil4n0r requested a review from GomezIvann March 5, 2024 10:38
@Mil4n0r Mil4n0r marked this pull request as draft March 5, 2024 10:44
@Mil4n0r Mil4n0r marked this pull request as ready for review March 5, 2024 10:59
…/halstack-react into Mil4n0r/divider-component
@GomezIvann GomezIvann self-assigned this Mar 5, 2024
@GomezIvann GomezIvann requested review from kukoc and removed request for kukoc March 5, 2024 12:07
@GomezIvann GomezIvann merged commit f6290b3 into master Mar 5, 2024
@GomezIvann GomezIvann deleted the Mil4n0r/divider-component branch March 5, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New component: Divider

5 participants