Fixing problems with NavTab inside website #1820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GomezIvann
suggested changes
Feb 13, 2024
Collaborator
GomezIvann
left a comment
GomezIvann
left a comment
There was a problem hiding this comment.
I've reviewed the PR and I think there's no need for so many changes. Removing the grid container from website (since there's no divider in there anymore) and also removing the z-index: -1 from the NavTabs do the job.
GomezIvann
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
/libdirectory./websiteas needed.Description
There was a problem where the NavTab with the style modifications was not covering the full width in the website.
It seems that it was due to using negative
z-index, the Underbar was not showing, changing the values and removing the unneeded grid inside the website layout should work.It is still needed to update the library used inside the website