Skip to content

Add title prop to Toggle Group component #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2023
Merged

Add title prop to Toggle Group component #1661

merged 1 commit into from
Jul 25, 2023

Conversation

@GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Jul 19, 2023 •
edited
Loading

Checklist

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Summary:

  • Implemented and documented a new prop for the Toggle Group options: title. Now users can add an HTML native tooltip in case there's no room for a regular label. It also serves as an accessible gateway for that icon-only scenario.
  • Component refactor, based con w3c toggle button pattern. Accessibility has also been improved to suit the use case of a toggle button.
  • The 'Icon usage' section has been updated with better explanations.

Closes #1658

@GomezIvann GomezIvann marked this pull request as ready for review July 19, 2023 12:55
@Jialecl Jialecl self-requested a review July 20, 2023 07:04
@Jialecl Jialecl self-assigned this Jul 20, 2023
@Jialecl Jialecl merged commit 6b2072d into master Jul 25, 2023
@Jialecl Jialecl deleted the gomezivann-toggle-group-title branch July 25, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jialecl Jialecl Jialecl approved these changes

Assignees

@Jialecl Jialecl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add title attribute to the Toggle Group options

3 participants

@GomezIvann @Jialecl