Fix custom icons sizing #1445
Merged
Fix custom icons sizing #1445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jialecl
reviewed
Jan 23, 2023
Collaborator
|
Should we consider centering in some way the icons if they are smaller than the space that they are trying to fill?
|
Jialecl
reviewed
Jan 23, 2023
Collaborator
|
As the SVGs were changed for the paginator to have the correct size I think the same can be done for the sidenav for example. |
Collaborator
Author
As we have already discussed, this is a problem of the SVG itself and not of our component. |
Jialecl
reviewed
Jan 25, 2023
Jialecl
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
/libdirectory./websiteas needed.Description
Trying to solve custom icons issue when the size was bigger or smaller than expected. I standardized the implementation: Icons will always fulfil their parent container to perfectly fit the component's anatomy.
Closes #1418