-
Notifications
You must be signed in to change notification settings - Fork 17
Closed
Labels
guidelines inconsistencyjiraThis task is referenced in a story of JiraThis task is referenced in a story of Jiranon-closableThis task is exempt from becoming stale or automatically closed.This task is exempt from becoming stale or automatically closed.
Description
While implementing a fix for the Chip component I noticed that the tokens of the current implementation are not matching the ones established on the specifications page of the component. This is a problem since the user can get confused when, for example, creating an advanced theme.
The task here is to review all the tokens of the component and synchronize implementation with the specs page.
- on-dark tokens do not exist in the implementation of the component anymore.
- Spacing tokens are not present in the implementation.
- Missing tokens on the specs page.
chip: {
backgroundColor: CORE_TOKENS.color_grey_200,
disabledBackgroundColor: CORE_TOKENS.color_grey_100,
fontFamily: CORE_TOKENS.type_sans,
fontSize: CORE_TOKENS.type_scale_03,
fontStyle: CORE_TOKENS.type_normal,
fontWeight: CORE_TOKENS.type_regular,
fontColor: CORE_TOKENS.color_black,
disabledFontColor: CORE_TOKENS.color_grey_500,
borderColor: CORE_TOKENS.color_transparent,
borderRadius: "80px",
borderThickness: CORE_TOKENS.border_width_0,
borderStyle: CORE_TOKENS.border_solid,
contentPaddingLeft: "16px",
contentPaddingRight: "16px",
contentPaddingTop: "0px",
contentPaddingBottom: "0px",
iconSize: "24px",
iconSpacing: "8px",
iconColor: CORE_TOKENS.color_grey_800,
hoverIconColor: CORE_TOKENS.color_grey_900,
activeIconColor: CORE_TOKENS.color_black,
disabledIconColor: CORE_TOKENS.color_grey_500,
focusColor: CORE_TOKENS.color_blue_600,
focusBorderStyle: CORE_TOKENS.border_solid,
focusBorderThickness: CORE_TOKENS.border_width_2,
focusBorderRadius: CORE_TOKENS.border_radius_medium,
}
Metadata
Metadata
Assignees
Labels
guidelines inconsistencyjiraThis task is referenced in a story of JiraThis task is referenced in a story of Jiranon-closableThis task is exempt from becoming stale or automatically closed.This task is exempt from becoming stale or automatically closed.

