notes edits #29
Merged
notes edits #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@manonthemat Thank you for your contributions, we really appreciate them and so does our community! In future, please assign your PRs to someone (usually @nelsonic or myself) for review - we like to ensure that all contributions are reviewed and aim to never merge our own PRs into master at dwyl 👍🏻 Thanks for reminding me that we need some serious updating to https://github.com/dwyl/contributing/blob/master/README.md 😊👌🏻 |
|
Got it and I agree that another pair of eyes is always a good idea 👍 In this particular case I didn't want anybody to have to go through all these lines, as the benefit of the PR is minimal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just markdown changes in the notes for lesson 26...
biggest change is that <Provider> is visible in the title as such