Skip to content

Multiple counters issue#40 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jun 16, 2018
Merged

Multiple counters issue#40 #41

merged 17 commits into from
Jun 16, 2018

Conversation

nelsonic
Copy link
Member

Working on adding Multiple Counters with tests for #40 ...
will assign when ready for review. 👍

@nelsonic nelsonic self-assigned this Jun 10, 2018
@codecov
Copy link

codecov bot commented Jun 10, 2018

Codecov Report

Merging #41 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #41   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          43     44    +1     
=====================================
+ Hits           43     44    +1
Impacted Files Coverage Δ
examples/counter-reset/counter.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 145202f...7d6871e. Read the comment docs.

@w0rm
Copy link

w0rm commented Jun 11, 2018

@nelsonic I’m not the author of this illustration, please provide correct credits. https://twitter.com/01k/status/986528602635358208?s=20

@nelsonic
Copy link
Member Author

@w0rm thank you for taking time to comment, 🎉
I have added the (CC BY 4.0) attribution below the image. ✅
Fantastic drawing BTW! ❤️
and great work on the Game tutorial: https://github.com/w0rm/creating-a-fun-game-with-elm 👾
and presentation: https://unsoundscapes.com/slides/2016-10-13-creating-a-fun-game-with-elm 💎

README.md Outdated
a _much_ more "user friendly" _explanation_
of **The Elm Architecture** ("TEA") <br />
is
[**Andrey Kuzmin**'s](https://github.com/w0rm) _fantastic_
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not my illustration and should not mention my name, Kolja Wilcke https://twitter.com/01k made it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@w0rm got it. thanks for clarifying. fixed. 👍

@w0rm
Copy link

w0rm commented Jun 11, 2018

@nelsonic thanks for correcting the attribution. All the credits should really go to Kolja.

@nelsonic nelsonic removed their assignment Jun 16, 2018
Copy link
Collaborator

@dwylbot dwylbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nelsonic LGTM! 🤖 ✅

nelsonic added 2 commits June 16, 2018 20:49
…nters-instances/index.html instead of duplicating code! for #40
…nters-instances/index.html instead of duplicating code! for #40
@dwylbot dwylbot merged commit 8097e4b into master Jun 16, 2018
@dwylbot dwylbot deleted the multiple-counters-issue#40 branch June 16, 2018 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants