Activity

1. nelsonic

   added

   questionFurther information is requestedFurther information is requested

   discuss

   on May 15, 2019
2. nelsonic commented on May 15, 2019

   

   nelsonic

   on May 15, 2019

   MemberAuthor

   More actions

   Relevant test:

   fields/test/url_test.exs

   Line 21 in a40df5c

   assert :error == Url.cast("www.test.com")
3. nelsonic commented on Dec 1, 2019

   

   nelsonic

   on Dec 1, 2019

   MemberAuthor

   More actions

   Sadly only 56.6% of websites use HTTPS: https://w3techs.com/technologies/details/ce-httpsdefault
   

   However most of the top sites use HTTPS: https://transparencyreport.google.com/https/overview
   

   The last thing we want is a person being blocked from adding a link to the @dwyl app because it does not start with https:// ... so think we may need to update the regular expression to be more permissive.
4. nelsonic

   added

   help wantedExtra attention is neededExtra attention is needed

   on Dec 1, 2019
5. ndrean commented on Sep 23, 2023

   

   ndrean

   on Sep 23, 2023

   Last edited by ndrean

   More actions

   @nelsonic
   Bumped into this. Maybe something like below if this is still relevant?

   > Enum.any?([:scheme, :authority, :host], &Map.get(URI.parse(url), &1))
   
   > u = URI.parse("www.test.com")
   %URI{
     scheme: nil,
     userinfo: nil,
     host: nil,
     port: nil,
     path: "://www.test.com",
     query: nil,
     fragment: nil
   }
   > Enum.any?([:scheme, :authority, :host], &Map.get(u,&1))
   false
   
   ##
   
   >u = URI.parse("://www.test.com")
   %URI{
     scheme: nil,
     userinfo: nil,
     host: nil,
     port: nil,
     path: "www.test.com",
     query: nil,
     fragment: nil
   }
   >Enum.any?([:scheme, :authority, :host], &Map.get(u,&1))
   false
   
   ##
   >u = URI.parse("ftp://www.test.com")
   %URI{
     scheme: "ftp",
     authority: "www.test.com",
     userinfo: nil,
     host: "www.test.com",
     port: 21,
     path: nil,
     query: nil,
     fragment: nil
   }
   >Enum.any?([:scheme, :authority, :host], &Map.get(u,&1))
   true
   
   > u = URI.parse("https://www.test.com?p=1")
   %URI{
     scheme: "https",
     authority: "www.test.com",
     userinfo: nil,
     host: "www.test.com",
     port: 443,
     path: nil,
     query: "p=1",
     fragment: nil
   }
   > Enum.any?([:scheme, :authority, :host], &Map.get(u,&1))
   true

   👀React with 👀1Reacted by Nelson