Skip to content

PR: Documentation #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 55 commits into from
Dec 5, 2019
Merged

PR: Documentation #11

merged 55 commits into from
Dec 5, 2019

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Nov 26, 2019

@nelsonic nelsonic added documentation Improvements or additions to documentation enhancement New feature or request in-progress labels Nov 26, 2019
@nelsonic nelsonic self-assigned this Nov 26, 2019
@nelsonic nelsonic changed the title Documentation PR: Documentation Nov 27, 2019
@nelsonic
Copy link
Member Author

@SimonLab we appear to not be able to run a bash script/command on GitHub CI
see: https://github.com/dwyl/elixir-auth-google/runs/325366614
image

Looks like there is a bit more work to send a report to Codecov using GitHub Actions ... 🤔
see: https://github.com/codecov/codecov-action

@nelsonic
Copy link
Member Author

I've attempted to follow the official instructions for uploading the Codecov (excoveralls.json) file,
but still getting error https://github.com/dwyl/elixir-auth-google/commit/82d1d1f82be4a5509d050a03739e7a0542670c0c/checks?check_suite_id=334000821
image

@SimonLab can you help with getting this to work? (or can we switch to Travis-CI till we can get a working example app with all our standard tools including coverage...?) Thanks!

@nelsonic nelsonic mentioned this pull request Nov 29, 2019
4 tasks
@nelsonic
Copy link
Member Author

The latest build appears to pass:
https://github.com/dwyl/elixir-auth-google/commit/82d1d1f82be4a5509d050a03739e7a0542670c0c/checks?check_suite_id=334000821
image
But in actual fact it's failing to send the report to Codecov
image

It eventually gives up trying to upload and GitHub actions considers this to be a successful outcome.
This is a "false positive" which is the worst possible outcome from a CI system. 😞

@nelsonic
Copy link
Member Author

nelsonic commented Dec 5, 2019

Hi @SimonLab!
As discussed on standup, this Docs++ PR is done! 🚀
Please review/comment (and merge if OK) the other PRs #21 & #22 first.
And then once those are complete I will assign this one to you for review.
Thanks! ✨

@nelsonic nelsonic marked this pull request as ready for review December 5, 2019 05:22
@nelsonic nelsonic assigned SimonLab and unassigned nelsonic Dec 5, 2019
@nelsonic nelsonic requested a review from SimonLab December 5, 2019 09:00
Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a few commits to fix some typos but otherwise looks great, thanks @nelsonic

@SimonLab SimonLab merged commit 3d7fa58 into master Dec 5, 2019
@SimonLab SimonLab deleted the add-docs-issue-#10 branch December 5, 2019 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants