Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop NodeJS 8 support, and default to 10 #143

Merged
merged 1 commit into from
Nov 29, 2020

Conversation

ath0mas
Copy link
Contributor

@ath0mas ath0mas commented Nov 28, 2020

Set Node requirement to oldest supported LTS = 10.
And test for >= 10.

To go with PR #141 adding node 14.


As of NodeJS 14 now LTS, 10 switched to Maintenance LTS, and 8 is not supported anymore by the Node Release working group.
See https://nodejs.org/en/about/releases/

(like done by other packages, like conventional-changelog, standard-version, ...)

@guardrails
Copy link
Contributor

guardrails bot commented Nov 28, 2020

⚠️ We detected security issues in this pull request:

Vulnerable Libraries (1)

More info on how to fix Vulnerable Libraries in Javascript.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@dwmkerr
Copy link
Owner

dwmkerr commented Nov 29, 2020

Love it, thank you @ath0mas!

@dwmkerr dwmkerr merged commit f7e0b06 into dwmkerr:master Nov 29, 2020
@ath0mas ath0mas deleted the feature/drop-node8 branch November 29, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants