Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define scala versions keys (eg scala212.value) #27

Merged
merged 2 commits into from
Jan 24, 2019
Merged

Conversation

dwijnand
Copy link
Owner

Fixes #11

WDYT @djspiewak?

@djspiewak
Copy link
Collaborator

What about making it Option[String], so we can be a bit more typeful about the ill-defined scenarios? I'm in favor of keeping the warning, just thinking about the exact value.

@dwijnand
Copy link
Owner Author

It's the more obvious type, but ergonomically annoying in 99% of cases. Thus the sanity check opt-in instead.

@dwijnand
Copy link
Owner Author

I'm not going to release this quite yet (I don't need it quite yet), so I'll merge this as is and we can forward-fix (or even revert - no sweat) this before releasing.

@dwijnand dwijnand merged commit c94cb6a into master Jan 24, 2019
@dwijnand dwijnand deleted the scala-version-keys branch January 24, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants