fix to allow configuration of other values via uri #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously any non uri options passed to a device would be stripped out. This makes the behavior consistent with how the Rails configuration works.
|
This looks good. It makes sense that someone might specify configuration both in the URI and in the main Rails configuration. |
|
Yes, our use case, for example, configures the Rails logger as well as substituting Sidekiq's logger with a different LogstashLogger instance. |
dwbutler
added a commit
that referenced
this pull request
Jul 26, 2015
fix to allow configuration of other values via uri
|
Released in 0.10.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously any non uri options passed to a device would be stripped out. This makes the behavior consistent with how the Rails configuration works.