Fix internal buffer logger #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The buffer implementation vendored from `Stud:Buffer` has an internal logger. However, it's called with non-standard arguments not supported by Ruby's standard Logger class. This fixes the issue by logging in the standard way. A new `buffer_logger` configuration variable is also exposed to allow the buffer logger to be set. Fixes #101
|
Any ideas on when this one might be merged and released? I am currently suffering some intermittent issues with logs getting to my source and really want some debug logging to try and figure it out. |
|
Released in 0.20.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buffer implementation vendored from
Stud:Bufferhas an internal logger. However, it's called with non-standard arguments not supported by Ruby's standard Logger class. This fixes the issue by logging in the standard way. A newbuffer_loggerconfiguration variable is also exposed to allow the buffer logger to be set.Fixes #101