-
Notifications
You must be signed in to change notification settings - Fork 3
feat(component): add <ToggleAndPattern />, <ToggleOrPattern /> components
#2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| // LICENSE : MIT | ||
| "use strict"; | ||
| const React = require("react"); | ||
| import {matchOr} from "./utils/match-props"; | ||
| export default class ToggleOrPattern extends React.Component { | ||
| getFlagNames() { | ||
| return Object.keys(this.props).filter(key => { | ||
| return key !== "children"; | ||
| }); | ||
| } | ||
|
|
||
| /** | ||
| * get components from `children` that matches key and value with own props. | ||
| * @returns {ReactComponent[]} | ||
| */ | ||
| getMatchedComponent() { | ||
| const children = [].concat(this.props.children); | ||
| const flagKeyNames = this.getFlagNames(); | ||
| return children.filter(child => { | ||
| // ignore text child | ||
| if (!child.props) { | ||
| return false; | ||
| } | ||
| // all match | ||
| return matchOr(flagKeyNames, this.props, child.props); | ||
| }); | ||
| }; | ||
|
|
||
| render() { | ||
| const components = this.getMatchedComponent(); | ||
| if (components.length === 0) { | ||
| return null; | ||
| } | ||
| if (components.length === 1) { | ||
| return components[0]; | ||
| } | ||
| return <div className="ToggleOrPattern"> | ||
| {components} | ||
| </div>; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| // LICENSE : MIT | ||
| "use strict"; | ||
| import ToggleAndPattern from "./ToggleAndPattern"; | ||
| import ToggleOrPattern from "./ToggleOrPattern"; | ||
| module.exports = { | ||
| // default: or pattern | ||
| TogglePattern: ToggleOrPattern, | ||
| ToggleOrPattern, | ||
| ToggleAndPattern | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| // LICENSE : MIT | ||
| "use strict"; | ||
| export function matchAnd(keys, parentProps, childProps) { | ||
| const childKeys = Object.keys(childProps); | ||
| // all match | ||
| return keys.every(parentKey => { | ||
| return childKeys.some(childKey => { | ||
| const parentValue = parentProps[parentKey]; | ||
| const childValue = childProps[childKey]; | ||
| if (childValue === parentValue) { | ||
| return true | ||
| } else if (childValue === undefined && parentKey === true) { | ||
| // <X attr /> | ||
| return true; | ||
| } | ||
| return false; | ||
| }); | ||
| }); | ||
| } | ||
| export function matchOr(keys, parentProps, childProps) { | ||
| const childKeys = Object.keys(childProps); | ||
| // some match | ||
| return keys.some(parentKey => { | ||
| return childKeys.some(childKey => { | ||
| const parentValue = parentProps[parentKey]; | ||
| const childValue = childProps[childKey]; | ||
| if (childValue === parentValue) { | ||
| return true | ||
| } else if (childValue === undefined && parentKey === true) { | ||
| // <X attr /> | ||
| return true; | ||
| } | ||
| return false; | ||
| }); | ||
| }); | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| const assert = require("power-assert"); | ||
| import React from "react"; | ||
| import {shallow} from 'enzyme'; | ||
| import ToggleAndPattern from "../src/ToggleAndPattern"; | ||
| class ComponentY extends React.Component { | ||
| render() { | ||
| return <div>Hidden</div> | ||
| } | ||
| } | ||
| class ComponentX extends React.Component { | ||
| render() { | ||
| return <div>Visible</div> | ||
| } | ||
| } | ||
| describe('<ToggleAndPattern />', () => { | ||
| it('renders 1 <ComponentX /> components', () => { | ||
| const result = shallow(<ToggleAndPattern isEditing={true}> | ||
| <ComponentX isEditing/> | ||
| <ComponentY/> | ||
| </ToggleAndPattern>); | ||
| assert(result.is(ComponentX)); | ||
| }); | ||
| it('renders 1 <ComponentY /> components', () => { | ||
| const result = shallow(<ToggleAndPattern isEditing={false}> | ||
| <ComponentX isEditing={true}/> | ||
| <ComponentY isEditing={false}/> | ||
| </ToggleAndPattern>); | ||
| assert(result.is(ComponentY)); | ||
| }); | ||
| it('renders 0 components', () => { | ||
| const result = shallow(<ToggleAndPattern isEditing={false}> | ||
| <ComponentX isEditing={true}/> | ||
| <ComponentY /> | ||
| </ToggleAndPattern>); | ||
| assert(result.node === null); | ||
| }); | ||
| it('renders 2 <ComponentX /> components', () => { | ||
| const wrapper = shallow(<ToggleAndPattern isEditing={true}> | ||
| <ComponentX isEditing={true}/> | ||
| <ComponentX isEditing={true}/> | ||
| </ToggleAndPattern>); | ||
| const result = wrapper.find(ComponentX); | ||
| assert(result.length === 2); | ||
| assert.equal(wrapper.html(), `<div class="ToggleAndPattern"><div>Visible</div><div>Visible</div></div>`) | ||
| }); | ||
| it('no renders <ComponentY /> components', () => { | ||
| const wrapper = shallow(<ToggleAndPattern isEditing={true}> | ||
| <ComponentY /> | ||
| </ToggleAndPattern>); | ||
| const result = wrapper.find(ComponentX); | ||
| assert(result.length === 0); | ||
| }); | ||
|
|
||
| it('match any type value', () => { | ||
| const wrapper = shallow(<ToggleAndPattern pattern="one"> | ||
| <ComponentX pattern="one"/> | ||
| <ComponentY pattern="two"/> | ||
| </ToggleAndPattern>); | ||
| assert(wrapper.is(ComponentX)); | ||
|
|
||
| const symbol = {}; | ||
| const wrapper1 = shallow(<ToggleAndPattern pattern={symbol}> | ||
| <ComponentX pattern={symbol}/> | ||
| <ComponentY pattern="two"/> | ||
| </ToggleAndPattern>); | ||
| assert(wrapper1.is(ComponentX)); | ||
| }); | ||
| it('safe handling mixed text', () => { | ||
| const wrapper = shallow(<ToggleAndPattern pattern={1}> | ||
| <ComponentX pattern={1}/> | ||
| text | ||
| <ComponentY pattern={2}/> | ||
| </ToggleAndPattern>); | ||
| assert(wrapper.is(ComponentX)); | ||
| }); | ||
| it('render match And pattern', () => { | ||
| const wrapper = shallow(<ToggleAndPattern pattern1={1} pattern2={2}> | ||
| <ComponentX pattern1={1} pattern2={2}/> | ||
| <ComponentY pattern1={1} /> | ||
| </ToggleAndPattern>); | ||
| assert(wrapper.is(ComponentX)); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
" TogglePattern ToggleAndPattern" is better