Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing decimals to count #136

Closed
AdaptingAFM opened this issue Feb 13, 2022 · 2 comments · Fixed by #139
Closed

Passing decimals to count #136

AdaptingAFM opened this issue Feb 13, 2022 · 2 comments · Fixed by #139
Assignees

Comments

@AdaptingAFM
Copy link

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
If count is equal to 2.5, return three animated spans: 2 with 100% the width, and one with 50% the width.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@srmagura
Copy link
Collaborator

Hey @AdaptingAFM. On one hand, this does sound like a nice convenience. On the other hand, I can't see many people using this feature.

I'm going to leave this open for a while — if it gets a nontrivial number of +1's, I'll consider implementing it. In the meantime, you could write your own component that accepts non-integer count and renders the appropriate <Skeleton />'s.

@srmagura srmagura self-assigned this Apr 7, 2022
@srmagura
Copy link
Collaborator

srmagura commented Apr 7, 2022

This is scheduled for implementation 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants