Skip to content

Conversation

@simontindallbjss
Copy link
Contributor

Creation of a SQL view that can be used by Romans team to automate data delivery to DVLA

Related issue: CB2-15838

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

jankichohan1
jankichohan1 previously approved these changes Jan 27, 2025
Copy link
Contributor

@jankichohan1 jankichohan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic makes sense

Copy link
Contributor

@reisedawson reisedawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it meets what you've explained through the sessions up to now. Just a question in here about case sensitivity of test type name matching.

Also, I know it's nitpicky, but could we get the tabs vs spaces thing consistent throughout please? I can see effort has been put in to making it align outside of this script, but once in here GH is rendering it weird because it looks like tabs are spanning 8 spaces in here instead of the 4 that it looks like have been used in other cases. I think making it either all tabs or all spaces would probably help.

Copy link
Contributor

@reisedawson reisedawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@simontindallbjss simontindallbjss merged commit 90863a1 into develop Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants