-
Notifications
You must be signed in to change notification settings - Fork 1
ANTS Report View Feature/cb2 15838 #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jankichohan1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic makes sense
reisedawson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it meets what you've explained through the sessions up to now. Just a question in here about case sensitivity of test type name matching.
Also, I know it's nitpicky, but could we get the tabs vs spaces thing consistent throughout please? I can see effort has been put in to making it align outside of this script, but once in here GH is rendering it weird because it looks like tabs are spanning 8 spaces in here instead of the 4 that it looks like have been used in other cases. I think making it either all tabs or all spaces would probably help.
reisedawson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Creation of a SQL view that can be used by Romans team to automate data delivery to DVLA
Related issue: CB2-15838