Skip to content

Conversation

@Nat-McCabe-BJSS
Copy link
Contributor

Description

As part of updating tsk-update-store to properly handle the dateAuthorised and dateRecieved columns, changes have to be made in NOP to account for the switching round of this data. This requires swapping the column names so that legacy data is stored under the correct columns.

Also note there is a previous commit under sql/00009_alter_plateSerialNumber_field.sql that was merged into this branch, hence why that file is there. It is unrelated to these changes

Related issue: CB2-11667

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

meys-bjss
meys-bjss previously approved these changes Jun 19, 2024
Copy link

@meys-bjss meys-bjss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes makes sense to me

meys-bjss
meys-bjss previously approved these changes Jun 21, 2024
Copy link

@meys-bjss meys-bjss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

@Nat-McCabe-BJSS Nat-McCabe-BJSS merged commit d295b63 into develop Jun 21, 2024
@Nat-McCabe-BJSS Nat-McCabe-BJSS deleted the feature/CB2-11667 branch June 21, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants