Refactor GetPMCWildSpawnType & GetPmcSide

dvize · Jul 18, 2024 · 7ab0659 · 7ab0659
1 parent 7b71257
commit 7ab0659
Showing 1 changed file with 14 additions and 18 deletions.
diff --git a/Bots/ProfilePreparationComponent.cs b/Bots/ProfilePreparationComponent.cs
@@ -307,32 +307,28 @@ private async UniTask InitializeBotInfos(StartingBotConfig startingBotConfig, st
 
         private WildSpawnType GetPMCWildSpawnType(WildSpawnType sptUsec, WildSpawnType sptBear)
         {
-            if (DefaultPluginVars.pmcFaction.Value == "Default")
+            switch(DefaultPluginVars.pmcFaction.Value)
             {
-                return BotSpawn.DeterminePMCFactionBasedOnRatio(sptUsec, sptBear);
-            }
-            else if (DefaultPluginVars.pmcFaction.Value == "USEC")
-            {
-                return WildSpawnType.pmcUSEC;
-            }
-            else if (DefaultPluginVars.pmcFaction.Value == "BEAR")
-            {
-                return WildSpawnType.pmcBEAR;
+                case "USEC":
+                    return WildSpawnType.pmcUSEC;
+                case "BEAR":
+                    return WildSpawnType.pmcBEAR;
+                default:
+                    return BotSpawn.DeterminePMCFactionBasedOnRatio(sptUsec, sptBear);
             }
-            return BotSpawn.DeterminePMCFactionBasedOnRatio(sptUsec, sptBear);
         }
 
         private EPlayerSide GetPMCSide(WildSpawnType wildSpawnType, WildSpawnType sptUsec, WildSpawnType sptBear)
         {
-            if (wildSpawnType == WildSpawnType.pmcUSEC)
-            {
-                return EPlayerSide.Usec;
-            }
-            else if (wildSpawnType == WildSpawnType.pmcBEAR)
+            switch(wildSpawnType)
             {
-                return EPlayerSide.Bear;
+                case WildSpawnType.pmcUSEC:
+                    return EPlayerSide.Usec;
+                case WildSpawnType.pmcBEAR:
+                    return EPlayerSide.Bear;
+                default:
+                    return EPlayerSide.Usec;
             }
-            return EPlayerSide.Usec;
         }
 
         private List<BotDifficulty> GetDifficultiesForSetting(string difficultySetting)