Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider length of string keys #308

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

mdrossmiller
Copy link
Contributor

take length of keys in the str_set hash into account so keys which are perfect sub-strings do not match incorrectly

take length into account so perfect sub-strings do not match incorrectly
@mikkelfj mikkelfj merged commit b5dbdd8 into dvidelabs:master Oct 29, 2024
5 checks passed
@mikkelfj
Copy link
Contributor

thanks

@mikkelfj
Copy link
Contributor

Note: this is a low impact issue unless str_set is used separately from flatcc as is. See also CHANGELOG note. Essentially str_set is used to detect if a header file has already been included in generated output. A false positive of a prefix match is unlikely due to hashing, and if it happens, worst case the end code might not compile without manual inclusion of a file assumed to be already included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants