Strict mode in core-js errors in Zotero 6

[dvanoni]

As a follow-up to #317:

• Determine why the use of strict mode in core-js v3.32.0 causes an error in Zotero 6
• Implement a robust fix

Resources

• core-js could use strict-mode for many files. zloirock/core-js#1269
• zloirock/core-js@11f4ec8
• zloirock/core-js@v3.32.0...v3.32.1

[dvanoni]

Maybe it's related to the fact that the "use strict"; statement comes after the banner in the bundled JS.

According to dev docs (emphasis added):

To invoke strict mode for an entire script, put the exact statement "use strict"; (or 'use strict';) before any other statements.

The bundled JS currently starts as follows:

if (!Zotero.Notero) {

// Make timer functions globally available in Zotero 6
if (typeof setTimeout === 'undefined') {
  var setTimeout = Zotero.setTimeout;
}
if (typeof clearTimeout === 'undefined') {
  var clearTimeout = Zotero.clearTimeout;
}

"use strict";
(() => {
  var __create = Object.create;
  var __defProp = Object.defineProperty;