[front] - refacto: get rid PokeLink
#8576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… component - Replaced instances of PokeLink with the LinkWrapper to standardize link components across different modules - Ensured LinkWrapper component is used consistently for all link elements in assistant, data_source_views, and data_sources columns, as well as in shadcn ui table components
- Deleted the PokeLink component from the project - Cleaned up associated code and references to streamline the UI module
…om column components - Deleted PokeLink imports from `assistants/columns.tsx`, `data_source_views/columns.tsx`, and `data_sources/columns.tsx` as they are no longer in use
flvndvd
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims at getting rid of the
PokeLinkcomponent and to use sparkleLinkWrapperinstead.Risk
Low, as it only touches poke
Deploy Plan
Deploy
front