Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[front] - fix: conditionally display select all button in ContentNodeTree #8574

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

JulesBelveze
Copy link
Contributor

Description

This PR only show 'Select All' button when there is a non-empty search query to avoid user confusion and interaction with an unnecessary button

References:

Risk

Deploy Plan

…tNodeTree

 - Only show 'Select All' button when there is a non-empty search query to avoid user confusion and interaction with an unnecessary button
 - Add margin to the 'Select All' button to improve spacing and visual alignment with other elements
Copy link
Contributor

@albandum albandum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JulesBelveze JulesBelveze merged commit 17e575f into main Nov 12, 2024
3 checks passed
@JulesBelveze JulesBelveze deleted the fix/slack-select-all-content-nodes branch November 12, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants