Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparkle effects #8554

Merged
merged 7 commits into from
Nov 13, 2024
Merged

Sparkle effects #8554

merged 7 commits into from
Nov 13, 2024

Conversation

Duncid
Copy link
Contributor

@Duncid Duncid commented Nov 8, 2024

Description

Sparkle Effect

Risk

n/a

@Duncid
Copy link
Contributor Author

Duncid commented Nov 8, 2024

@philipperolet not sure why there are multiple package-lock changes like that.
Normally, changes should be contained now in just tailwind config and new files.

@Duncid
Copy link
Contributor Author

Duncid commented Nov 8, 2024

I removed the package-lock weird stuff and now I can't get it to work.
Does it work for you @philipperolet ?

@philipperolet
Copy link
Contributor

Will have a look first thing Tuesday

@Duncid
Copy link
Contributor Author

Duncid commented Nov 12, 2024

Gentle ping @philipperolet ^^'

@philipperolet
Copy link
Contributor

👋 Hey
Fixed your issue. The changes you made let the rainbow show a little by transparency in the div, is that intentional?

Copy link
Contributor

@philipperolet philipperolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Thanks, left a com

@Duncid
Copy link
Contributor Author

Duncid commented Nov 12, 2024

👋 Hey
Fixed your issue.

Thanks so much, I'm very curious, what did I do wrong?

The changes you made let the rainbow show a little by transparency in the div, is that intentional?

Yes

@philipperolet
Copy link
Contributor

The tailwind config was malformed, probably a copy paste issue

@Duncid Duncid merged commit 3f7c39e into main Nov 13, 2024
3 checks passed
@Duncid Duncid deleted the sparkle-effects branch November 13, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants