Skip to content

Rewrite Succinct Attestation #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rewrite Succinct Attestation #71

wants to merge 1 commit into from

Conversation

fed-franz
Copy link
Contributor

@fed-franz fed-franz commented Jun 10, 2025

Implements #72

@fed-franz fed-franz linked an issue Jun 10, 2025 that may be closed by this pull request
Neotamandua
Neotamandua previously approved these changes Jun 10, 2025
Copy link
Member

@Neotamandua Neotamandua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added some comments. Feel free to address them (I don't have a strong opinion on these).


On average, eligible provisioners will then participate in committees with a frequency and power proportional to their stakes.

### Extraction
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, since Deterministic Sortition also discusses extraction, it would make sense to me to first explain and introduce Extraction, and then have the section about Deterministic Sortition afterwards.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a subsection of Deterministic Sortition. In general, I find it clearer to first explain the main idea and then delve into details. Describing the details of a single extraction before saying what the Deterministic Sortition is seems confusing to me.

@fed-franz fed-franz linked an issue Jun 10, 2025 that may be closed by this pull request
Copy link
Member

@HDauven HDauven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice read, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content: Review SA Consensus
3 participants