-
Notifications
You must be signed in to change notification settings - Fork 5
Rewrite Succinct Attestation #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3a0b6a9
to
8cfeb1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added some comments. Feel free to address them (I don't have a strong opinion on these).
|
||
On average, eligible provisioners will then participate in committees with a frequency and power proportional to their stakes. | ||
|
||
### Extraction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, since Deterministic Sortition also discusses extraction, it would make sense to me to first explain and introduce Extraction, and then have the section about Deterministic Sortition afterwards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a subsection of Deterministic Sortition. In general, I find it clearer to first explain the main idea and then delve into details. Describing the details of a single extraction before saying what the Deterministic Sortition is seems confusing to me.
8cfeb1b
to
7da0a05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice read, LGTM
Implements #72