Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge contents of upstream zkcrypto/bls12_381 #116

Merged
merged 3 commits into from
Jun 7, 2023
Merged

Merge contents of upstream zkcrypto/bls12_381 #116

merged 3 commits into from
Jun 7, 2023

Conversation

ureeves
Copy link
Member

@ureeves ureeves commented Jun 1, 2023

No description provided.

@moCello moCello requested a review from miloszm June 2, 2023 12:06
@moCello moCello marked this pull request as ready for review June 2, 2023 12:06
Copy link

@miloszm miloszm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nit question: why bench functions and tests related to uncompressed have been removed?

@moCello moCello linked an issue Jun 2, 2023 that may be closed by this pull request
@moCello moCello mentioned this pull request Jun 2, 2023
@moCello
Copy link
Member

moCello commented Jun 2, 2023

Might have been a mistake. Where they in zkcrypto/bls? Can you point me to the file?

Eduardo Leegwater Simões added 2 commits June 5, 2023 19:09
@moCello moCello merged commit 1dcced1 into master Jun 7, 2023
@moCello moCello deleted the zkcrypto branch June 7, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge our implementation with upstream implementation
3 participants