perf(analyzer): index qualified reference lookups - #769
Merged
duriantaco merged 2 commits intoAug 25, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #768
Summary
Knocks down the empirical O(n^2) scaling.
Measured Performance Improvement
_mark_refscumulative time: 1213.7 s -> 84.5sstr.startswithcalls from_mark_refs: 2.661 billion -> 1.965 million_mark_refs(scipy specifically is not as badly hit by this particular quadratic scaling relative to its size as a repo)Note: I doubt this completely maxes out possible perf wins in
_mark_refs; I thought the maintainer might find a smaller footprint/relatively straightforward code change from me that specifically targets the O(n^2) scaling with indexing more palatable than a larger refactor, given how cognitively complex and important this function is.Validation
AI Use Disclosure
Profiled targeted and and potential O(n^2) identified by hand using cProfile. Codex implemented an indexing scheme and the sorting/bisection. Reviewed according to skylos repository review guidelines using GPT-5.6 Sol and Opus 5.0. Second commit was partly based on my own by-hand simplification findings.