Allow types other than string slices for local paths #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once std has |
|
Rebased. Ping @durch |
|
@jplatte I have no strong opinions here, as long as we keep making the API more ergonomic. Having a |
|
Awesome. By the way, how about setting up a dev chat? (I personally prefer Matrix, Zulip would be cool too) |
durch
added a commit
that referenced
this pull request
Sep 29, 2020
* Allow types other than string slices for local paths (#119) * 0.26.0 Co-authored-by: Jonas Platte <jplatte@users.noreply.github.com>
|
@jplatte published to crates.io as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, local paths obtained through directory traversal,
tempfile::NamedFile::pathor anything like that would first have to be converted to strings, which does UTF8 validation and is just generally pointless boilerplate.This is a breaking change since it can break type inference (for example if people were calling
.put_object_stream(my_local_path.as_ref(), my_s3_path)).