Skip to content

Commit

Permalink
content shell drt: Make sure to always print #CRASHED lines.
Browse files Browse the repository at this point in the history
Before, they were dropped if crashes happened after text output had already
been printed (e.g. if a test crashed while generating the output bitmap).

BUG=218886

Review URL: https://codereview.chromium.org/12751008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188882 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
thakis@chromium.org committed Mar 19, 2013
1 parent eade45b commit bf27b36
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions content/shell/webkit_test_controller.cc
Original file line number Diff line number Diff line change
Expand Up @@ -149,12 +149,12 @@ void WebKitTestResultPrinter::AddMessageRaw(const std::string& message) {
}

void WebKitTestResultPrinter::AddErrorMessage(const std::string& message) {
if (!capture_text_only_)
*error_ << message << "\n";
if (state_ != DURING_TEST)
return;
PrintTextHeader();
*output_ << message << "\n";
if (!capture_text_only_)
*error_ << message << "\n";
PrintTextFooter();
PrintImageFooter();
}
Expand Down

0 comments on commit bf27b36

Please sign in to comment.