Skip to content

Commit

Permalink
History: Always show sync notification if the user is signed in.
Browse files Browse the repository at this point in the history
BUG=229030
TEST=Sign in to Chrome, go to advanced sync settings and disable
the "history" datatype. Visit chrome://history and ensure that it
says "Showing history from this device" at the top of the page.

Review URL: https://chromiumcodereview.appspot.com/14170006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193742 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
dubroy@chromium.org committed Apr 11, 2013
1 parent 8ae47ac commit 5eeeba2
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion chrome/browser/resources/history/history.js
Original file line number Diff line number Diff line change
Expand Up @@ -457,10 +457,12 @@ HistoryModel.prototype.addResults = function(info, results) {
lastDay = thisDay;
}

if (loadTimeData.getBoolean('isFullHistorySyncEnabled')) {
if (loadTimeData.getBoolean('isUserSignedIn')) {
if (info.hasSyncedResults) {
this.view_.showNotification(loadTimeData.getString('hasSyncedResults'));
} else {
// TODO(dubroy): This resource should be renamed, since it's not just used
// when there are no results from the server.
this.view_.showNotification(
loadTimeData.getString('noResponseFromServer'));
}
Expand Down

0 comments on commit 5eeeba2

Please sign in to comment.