forked from expo/expo
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[docs] Update E2E tests on EAS Build (expo#26391)
# Why <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> The guide is outdated as Detox configuration and filenames created during the process have changed minorly. I recently followed the guide and tested the example myself to find out about these updates. # How <!-- How did you build this feature or fix this bug and why? --> This PR: - Updates the filename **detox.config.js** references to **.detoxrc.js** - Updates the filename **homeScreen.e2e.js** references to **homeScreen.test.js** as using `.e2e.js` fails the test within the step "Build success hook" on EAS Build. - Updates the guide to follow our writing style guide for [second person voice](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md#write-in-the-second-person) and other changes - Updates internal link to point towards the correct collapsible and fix another internal link for eas.json schema - Uses `BoxLink` to link to example repo on GitHub. # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> Run docs locally and visit # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
- Loading branch information
1 parent
4464b80
commit e479580
Showing
2 changed files
with
76 additions
and
44 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters