Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cbor2.loads directly to avoid a deprecation warning #181

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

jlaine
Copy link
Contributor

@jlaine jlaine commented Oct 23, 2023

Starting with version 5.5.0 of cbor2, importing the cbor2.decoder module triggers a deprecation warning. We depend on cbor2 version 5.4.6 or better which all feature cbor2.loads so use it.

Starting with version 5.5.0 of `cbor2`, importing the `cbor2.decoder`
module triggers a deprecation warning. We depend on `cbor2` version
5.4.6 or better which all feature `cbor2.loads` so use it.
@CLAassistant
Copy link

CLAassistant commented Oct 23, 2023

CLA assistant check
All committers have signed the CLA.

@MasterKale MasterKale merged commit aa21cb2 into duo-labs:master Oct 31, 2023
8 checks passed
@MasterKale MasterKale added this to the v1.11.1 milestone Oct 31, 2023
@MasterKale
Copy link
Collaborator

@jlaine @miketheman This fix is now available in webauthn==1.11.1 https://pypi.org/project/webauthn/1.11.1/

@miketheman
Copy link

Thanks @MasterKale for the speedy merge and release!

@jlaine jlaine deleted the no-cbor2-decoder branch November 1, 2023 10:52
@jlaine
Copy link
Contributor Author

jlaine commented Nov 1, 2023

@MasterKale fantastic, thanks for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants