Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installable python module #641

Closed
wants to merge 1 commit into from
Closed

Conversation

ipmb
Copy link

@ipmb ipmb commented Jan 9, 2020

This moves the files around to make a cloudmapper Python package that can be pip installed and uploaded to PyPI. The changes are:

  • move all modules into a top-level namespace
  • create a __main__.py so you can run python -m cloudmapper
  • add a setup.py and MANIFEST.in to make it pip installable and create cloudmapper console script on install
  • store generated files in a cloudmapper-report directory in the current working directory. web files are copied into this from the python package

Tests pass and the few commands I've run work, but I haven't tested all the commands manually yet. Auditor and docs need a pass too.

refs #595 #1

@0xdabbad00
Copy link
Collaborator

Oh wow, this is a big PR. Thank you @ipmb, and sorry I hadn't gotten to this until now. This seems like a good idea. It is such a big architectural change though that I'll need to test a bunch of things with it.

@0xdabbad00 0xdabbad00 mentioned this pull request Jun 10, 2020
@0xdabbad00 0xdabbad00 closed this Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants